feat(fs): add timeouts to atomic operations #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-f
changed the title
julien-f
reviewed
Oct 15, 2018
@xen-orchestra/fs/src/abstract.js
Outdated
| @@ -121,7 +127,7 @@ export default class RemoteHandlerAbstract { | |||
| newPath: string, | |||
| { checksum = false }: Object = {} | |||
| ) { | |||
| let p = this._rename(oldPath, newPath) | |||
| let p = timeout.call(this._rename(oldPath, newPath), 10000) | |||
There was a problem hiding this comment.
p is redefined when we have checksum : L.132
There was a problem hiding this comment.
You should use DEFAULT_TIMEOUT 😉
julien-f
requested changes
Oct 15, 2018
julien-f
requested changes
Oct 16, 2018
julien-f
requested changes
Oct 16, 2018
CHANGELOG.md
Outdated
| @@ -24,6 +24,7 @@ | |||
| - xo-server-usage-report v0.7.0 | |||
| - xo-server v5.29.0 | |||
| - xo-web v5.29.0 | |||
| - @xen-orchestra/fs v0.4.0 | |||
There was a problem hiding this comment.
Please move it on top because it's a dependency of other packages to help with the (in order) release process 🙂
Enishowk
force-pushed
the
feat-timeout-fs
branch
from
5bd3e98
to
29eb787
Compare
julien-f
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3467
Check list
Fixes #007)${name} v${new version})Process
WiP:(Work in Progress) if not ready to be merged