fix(xo-web): Hide creation date if not available #3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-f
reviewed
Feb 11, 2019
julien-f
reviewed
Feb 12, 2019
| @@ -54,12 +54,12 @@ function toTimestamp(date) { | |||
| return timestamp | |||
| } | |||
|
|
|||
| const ms = parseDateTime(date) | |||
| if (!ms) { | |||
| const ms = parseDateTime(date).getTime() | |||
There was a problem hiding this comment.
What if date does not respect the expected format (%Y%m%dT%H:%M:%SZ)?
There was a problem hiding this comment.
We have problem !
Cannot read property 'getTime' of null
There was a problem hiding this comment.
I just modified it. Better ?
There was a problem hiding this comment.
Yep, at least it does not break anymore 🙂
pdonias
requested changes
Feb 12, 2019
| @@ -55,7 +55,7 @@ function toTimestamp(date) { | |||
| } | |||
|
|
|||
| const ms = parseDateTime(date) | |||
| if (!ms) { | |||
| if (!ms || ms.getTime() === 0) { | |||
There was a problem hiding this comment.
ms should contain milliseconds. So maybe something like that:
const ms = parseDateTime(date)?.getTime?.()
if (ms === undefined || ms === 0) {
return null
}
return Math.round(ms / 1000)There was a problem hiding this comment.
I think the second ?. is unnecessary.
Also you can use the ternary operator instead of the if statement.
julien-f
reviewed
Feb 12, 2019
Enishowk
force-pushed
the
georges-fix-installtime
branch
from
b9647f8
to
c702647
Compare
pdonias
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3953
Check list
Fixes #007)CHANGELOG.unreleased.md:${name} v${new version})Process
WiP:(Work in Progress) if not ready to be merged