feat(xo-web/vm-import) Don't block the UI when dropping a big OVA file #4018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nraynaud
changed the title
nraynaud
changed the title
|
Confirmed that it doesn't block the UI with a big file, and can import a small file. |
pdonias
requested changes
Mar 8, 2019
| const { name } = file | ||
|
|
||
| info(_('startVmImport'), name) | ||
|
|
||
| if (data.tables) { |
pdonias
requested changes
Apr 1, 2019
| const { name } = file | ||
|
|
||
| info(_('startVmImport'), name) | ||
|
|
||
| if (data && data.tables) { |
| @@ -12,10 +12,10 @@ const GRAIN_ADDRESS_OFFSET = 56 | |||
| */ | |||
| export default async function readVmdkGrainTable(fileAccessor) { | |||
| const getLongLong = (buffer, offset, name) => { | |||
| if (buffer.length < offset + 8) { | |||
| if (buffer.byteLength < offset + 8) { | |||
There was a problem hiding this comment.
I have no idea if this change is ok.
pdonias
approved these changes
Apr 2, 2019
pdonias
requested changes
Apr 2, 2019
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| - [SR/Disk] Disable actions on unmanaged VDIs [#3988](https://github.com/vatesfr/xen-orchestra/issues/3988) (PR [#4000](https://github.com/vatesfr/xen-orchestra/pull/4000)) | |||
| - [Pool] Specify automatic networks on a Pool [#3916](https://github.com/vatesfr/xen-orchestra/issues/3916) (PR [#3958](https://github.com/vatesfr/xen-orchestra/pull/3958)) | |||
| - [Import] Avoid blocking the UI when dropping a big OVA file on the UI (PR [#4018](https://github.com/vatesfr/xen-orchestra/pull/4018)) | |||
There was a problem hiding this comment.
Please rebase on master and add xo-vmdk-to-vhd to the Changelog.
nraynaud
force-pushed
the
nr-dont-block-ui-in-ova-import
branch
from
3ff7383
to
a4bb915
Compare
pdonias
approved these changes
Apr 4, 2019
|
Don't forget to check the PR checkboxes when done or irrelevant so we know when it's ready to be merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
Fixes #007)CHANGELOG.unreleased.md:${name} v${new version})Process
WiP:(Work in Progress) if not ready to be merged