feat(xo-web/vm): Migrate: improve modal #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajaa-BARHTAOUI
force-pushed
the
rajaa-improve-madal-migrate-vm
branch
from
7e88b7d
to
352a7ab
Compare
|
Regarding the screenshot: I'd like we insist more on the "optional" thing for selecting a SR for each VDI (to be sure people understand it's not mandatory) |
Rajaa-BARHTAOUI
force-pushed
the
rajaa-improve-madal-migrate-vm
branch
from
d15f7c4
to
20f0bef
Compare
badrAZ
approved these changes
Apr 8, 2019
pdonias
requested changes
Apr 8, 2019
| @@ -1608,7 +1608,7 @@ const messages = { | |||
| migrateVmNoTargetHostMessage: 'A target host is required to migrate a VM', | |||
| migrateVmNoDefaultSrError: 'No default SR', | |||
| migrateVmNotConnectedDefaultSrError: 'Default SR not connected to host', | |||
| chooseSrForEachVdisModalSelectSr: 'For each VDI, select an SR:', | |||
| chooseSrForEachVdisModalSelectSr: 'For each VDI, select an SR (optional):', | |||
There was a problem hiding this comment.
Remove colon and make sure it doesn't break other locales.
pdonias
requested changes
Apr 9, 2019
Rajaa-BARHTAOUI
force-pushed
the
rajaa-improve-madal-migrate-vm
branch
from
5ee12b9
to
9226c9a
Compare
pdonias
approved these changes
Apr 11, 2019
nraynaud
pushed a commit
that referenced
this pull request
Apr 12, 2019
Fixes #3326 - auto-select default SR as main SR - hide optional per-VDI SR selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3326
Screenshots
Check list
Fixes #007)CHANGELOG.unreleased.md:${name} v${new version})Process
WiP:(Work in Progress) if not ready to be merged