fix(xo-web/backup-ng): display user errors in the form #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badrAZ
changed the title
| : setting | ||
| ) | ||
| return mapValues(settings, predicate) |
| @@ -134,11 +136,13 @@ const getOptionRenderer = ({ label }) => <span>{_(label)}</span> | |||
|
|
|||
| const createDoesRetentionExist = name => { | |||
| const predicate = setting => setting[name] > 0 | |||
| return ({ propSettings, settings = propSettings }) => settings.some(predicate) | |||
| return ({ settings }) => some(settings, predicate) | |||
There was a problem hiding this comment.
You can inline predicate.
Why you use _.some instead of some? settings is an Array ?
| newSchedule.name !== oldSchedule.name || | ||
| newSchedule.timezone !== oldSchedule.timezone || | ||
| newSchedule.enabled !== oldSchedule.enabled | ||
| ) { |
There was a problem hiding this comment.
Why do you remove this ? it avoid editSchedule if shedule doesn't change, right?
badrAZ
force-pushed
the
backupNg-schedules
branch
3 times, most recently
from
6ade22c
to
318f9b3
Compare
badrAZ
force-pushed
the
backupNg-schedules
branch
from
318f9b3
to
46802d3
Compare
Rajaa-BARHTAOUI
approved these changes
Aug 9, 2019
pdonias
requested changes
Aug 13, 2019
badrAZ
changed the title
badrAZ
force-pushed
the
backupNg-schedules
branch
from
46802d3
to
c520f2b
Compare
pdonias
requested changes
Sep 5, 2019
badrAZ
force-pushed
the
backupNg-schedules
branch
from
f0dcc88
to
d3a5ae3
Compare
badrAZ
changed the title
pdonias
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3831
Check list
Fixes #007)CHANGELOG.unreleased.md:${name} v${new version})Process
WiP:(Work in Progress) if not ready to be merged