Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/xoa): remove "Updates" & "Licenses" tabs for non admins #4526

Merged
merged 3 commits into from Sep 19, 2019

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Sep 17, 2019

Fixes support#1753

Check list

Check items when done or if not relevant

  • PR reference the relevant issue (e.g. Fixes #007)
  • if UI changes, a screenshot has been added to the PR
  • if xo-server API changes, the corresponding test has been added to/updated on xo-server-test
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • documentation updated
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

Screenshots

Capture_2019-09-17_11:36:10

Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rebase your branch.

@pdonias pdonias merged commit 7f24afc into master Sep 19, 2019
@pdonias pdonias deleted the pierre-fix-xoa-tabs branch September 19, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants