Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs/configuration): hosthostname #4681

Merged
merged 1 commit into from Nov 26, 2019

Conversation

billgertz
Copy link
Contributor

@billgertz billgertz commented Nov 26, 2019

The attribute 'hostname' is incorrectly documented as 'host'. Updated all occurrences of attribute 'host' to 'hostname'.

Check list

Check if done.

Strikethrough if not relevant: example (doc).

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

The attribute 'hostname' is incorrectly documented as 'host'. Updated all occurrences of attribute 'host' to 'hostname'.
@julien-f julien-f changed the title Fix documentation for [[http.listen]] block mods fix(docs/configuration): hosthostname Nov 26, 2019
@julien-f julien-f merged commit b313eb1 into vatesfr:master Nov 26, 2019
@julien-f
Copy link
Member

@billgertz Thank you!

@billgertz
Copy link
Contributor Author

billgertz commented Nov 26, 2019

@julien-f No problem - it was a pleasure.

@billgertz billgertz deleted the patch-1 branch November 26, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants