Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/restore-legacy,file-restore-legacy): ignore proxy remotes #5124

Merged
merged 8 commits into from Jul 2, 2020

Conversation

badrAZ
Copy link
Contributor

@badrAZ badrAZ commented Jul 1, 2020

Legacy restore doesn't support proxy remotes

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

Legacy restore don't support proxied remotes
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we need to take backup.list into account in the same PR.

@badrAZ badrAZ changed the title fix(xo-web/restore-legacy): ignore proxy remotes fix(xo-web/restore-legacy,file-restore-legacy): ignore proxy remotes Jul 2, 2020
@@ -11,6 +11,8 @@

> Users must be able to say: “I had this issue, happy to know it's fixed”

- [Restore legacy, File restore legacy] Fix mount error in case of existant proxy remotes (PR [#5124](https://github.com/vatesfr/xen-orchestra/pull/5124))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdonias pdonias merged commit 4636109 into master Jul 2, 2020
@pdonias pdonias deleted the legacyBackupOmitProxyRemotes branch July 2, 2020 14:23
phil-flex pushed a commit to phil-flex/xen-orchestra that referenced this pull request Jul 13, 2020
Storycrafter pushed a commit to Storycrafter/xen-orchestra that referenced this pull request Jul 23, 2020
phil-flex pushed a commit to phil-flex/xen-orchestra that referenced this pull request Aug 24, 2020
phil-flex pushed a commit to phil-flex/xen-orchestra that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants