New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(xo-web/restore-legacy,file-restore-legacy): ignore proxy remotes #5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legacy restore don't support proxied remotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, we need to take backup.list
into account in the same PR.
badrAZ
changed the title
fix(xo-web/restore-legacy): ignore proxy remotes
fix(xo-web/restore-legacy,file-restore-legacy): ignore proxy remotes
Jul 2, 2020
julien-f
reviewed
Jul 2, 2020
CHANGELOG.unreleased.md
Outdated
@@ -11,6 +11,8 @@ | |||
|
|||
> Users must be able to say: “I had this issue, happy to know it's fixed” | |||
|
|||
- [Restore legacy, File restore legacy] Fix mount error in case of existant proxy remotes (PR [#5124](https://github.com/vatesfr/xen-orchestra/pull/5124)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rajaa-BARHTAOUI
approved these changes
Jul 2, 2020
pdonias
approved these changes
Jul 2, 2020
phil-flex
pushed a commit
to phil-flex/xen-orchestra
that referenced
this pull request
Jul 13, 2020
Legacy restore doesn't support proxy remotes
Storycrafter
pushed a commit
to Storycrafter/xen-orchestra
that referenced
this pull request
Jul 23, 2020
Legacy restore doesn't support proxy remotes
phil-flex
pushed a commit
to phil-flex/xen-orchestra
that referenced
this pull request
Aug 24, 2020
Legacy restore doesn't support proxy remotes
phil-flex
pushed a commit
to phil-flex/xen-orchestra
that referenced
this pull request
Aug 24, 2020
Legacy restore doesn't support proxy remotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy restore doesn't support proxy remotes
Check list
Fixes #007
orSee xoa-support#42
)CHANGELOG.unreleased.md
:${name} v${new version}
)cron/parse.spec.js
)xo-server
API changes, the corresponding test has been added to/updated onxo-server-test
Process
WiP:
(Work in Progress) if not ready to be mergedFrom the Four Agreements: