Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server#_migrateVmWithStorageMotion): improve migration error #5306

Merged
merged 6 commits into from Oct 14, 2020

Conversation

badrAZ
Copy link
Contributor

@badrAZ badrAZ commented Oct 1, 2020

Fixes #5282

Test done: migrate a VM to a pool with default SR

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@badrAZ badrAZ force-pushed the improveMigrationErrorMessage branch from 0b2c065 to 41a5204 Compare October 1, 2020 15:07
@badrAZ badrAZ self-assigned this Oct 2, 2020
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
@julien-f julien-f self-requested a review October 13, 2020 13:47
@julien-f julien-f merged commit a7fe645 into master Oct 14, 2020
@julien-f julien-f deleted the improveMigrationErrorMessage branch October 14, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VM] Improve the error message on the VM migration
3 participants