New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(xo-web/user): use default filter when custom filter is unset #5321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuRA
changed the title
fix(xo-web/user/userFilters): set default filter as none if it is not defined
fix(xo-web/user/userFilters): reset default filter if he is detached
Oct 12, 2020
badrAZ
suggested changes
Oct 14, 2020
@@ -3009,6 +3009,7 @@ export const setDefaultHomeFilter = (type, name) => { | |||
const { user } = xo | |||
const { preferences } = user | |||
const defaultFilters = (preferences && preferences.defaultHomeFilters) || {} | |||
name = name === null ? undefined : name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name
is used one time, you can inline it.
pdonias
requested changes
Oct 19, 2020
badrAZ
reviewed
Oct 26, 2020
badrAZ
approved these changes
Oct 27, 2020
pdonias
approved these changes
Oct 27, 2020
pdonias
changed the title
fix(xo-web/user/userFilters): reset default filter if he is detached
fix(xo-web/user): use default filter when custom filter is unset
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
Fixes #007
orSee xoa-support#42
)CHANGELOG.unreleased.md
:${name} v${new version}
)cron/parse.spec.js
)xo-server
API changes, the corresponding test has been added to/updated onxo-server-test
Process
WiP:
(Work in Progress) if not ready to be mergedFrom the Four Agreements: