Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/user): use default filter when custom filter is unset #5321

Merged
merged 7 commits into from Oct 27, 2020
Merged

fix(xo-web/user): use default filter when custom filter is unset #5321

merged 7 commits into from Oct 27, 2020

Conversation

MathieuRA
Copy link
Member

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA requested a review from badrAZ October 12, 2020 13:49
@MathieuRA MathieuRA changed the title fix(xo-web/user/userFilters): set default filter as none if it is not defined fix(xo-web/user/userFilters): reset default filter if he is detached Oct 12, 2020
@@ -3009,6 +3009,7 @@ export const setDefaultHomeFilter = (type, name) => {
const { user } = xo
const { preferences } = user
const defaultFilters = (preferences && preferences.defaultHomeFilters) || {}
name = name === null ? undefined : name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is used one time, you can inline it.

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@badrAZ badrAZ requested a review from pdonias October 14, 2020 08:20
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from badrAZ October 26, 2020 09:39
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from badrAZ October 26, 2020 16:40
@badrAZ badrAZ requested a review from pdonias October 27, 2020 08:06
@pdonias pdonias changed the title fix(xo-web/user/userFilters): reset default filter if he is detached fix(xo-web/user): use default filter when custom filter is unset Oct 27, 2020
@pdonias pdonias merged commit b3eb127 into vatesfr:master Oct 27, 2020
@MathieuRA MathieuRA deleted the resetDefaultFilter branch October 30, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants