fix(xo-web/editable/number): throw error if onChange fails

[MathieuRA]

Check list

Check if done, if not relevant leave unchecked.

• PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
• if UI changes, a screenshot has been added to the PR
• documentation updated
• CHANGELOG.unreleased.md:
  • enhancement/bug fix entry added
  • list of packages to release updated (${name} v${new version})
• I have tested added/updated features (and impacted code)
  • unit tests (e.g. cron/parse.spec.js)
  • if xo-server API changes, the corresponding test has been added to/updated on xo-server-test
  • at least manual testing

Process

1. create a PR as soon as possible
2. mark it as WiP: (Work in Progress) if not ready to be merged
3. when you want a review, add a reviewer (and only one)
4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

1. Be impeccable with your word.
2. Don't take anything personally.
3. Don't make assumptions.
4. Always do your best.

[badrAZ]

The code above the onChange cannot throw an error.

[pdonias]

I don't understand the point of catching an error just to rethrow it.

[julien-f]

Indeed, the important change appears to be the await.

[MathieuRA]

I don't understand the point of catching an error just to rethrow it.

The current behaviour is: if we edit a number and it's failing, the UI are not displaying an error, and for the user it's look like it worked.
Eg: If you try to edit a rate limit network as viewer, the modification will fail, and a success tooltip will appear next to the input

By throwing an error in the case of failure, the error tooltip is displayed

[julien-f]

@MathieuRA Your comment does not explain why the try/catch is necessary.

Because what you're doing right now is catch an exception and then rethrow it, which is the same as not catching it in the first place.

[MathieuRA]

Ho okay, i understand.

So only the await is necessary