Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server): log missing pools #5768

Merged
merged 6 commits into from May 7, 2021
Merged

fix(xo-server): log missing pools #5768

merged 6 commits into from May 7, 2021

Conversation

badrAZ
Copy link
Contributor

@badrAZ badrAZ commented May 5, 2021

Fixes #2844

UI
image
Backup report
image

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@badrAZ badrAZ requested a review from julien-f May 6, 2021 08:18
@badrAZ badrAZ self-assigned this May 6, 2021
@badrAZ badrAZ requested a review from julien-f May 6, 2021 09:25
@badrAZ badrAZ requested a review from julien-f May 7, 2021 07:32
@julien-f julien-f changed the title fix(xo-server, xo-server-backup-reports): log missing pools fix(xo-server): log missing pools May 7, 2021
@badrAZ badrAZ removed the request for review from julien-f May 7, 2021 09:34
@badrAZ badrAZ requested a review from julien-f May 7, 2021 09:38
@badrAZ badrAZ requested a review from julien-f May 7, 2021 13:58
@julien-f julien-f merged commit 8ac17ab into master May 7, 2021
@julien-f julien-f deleted the improveSmartBackup branch May 7, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup - No matching pools due to host-uuid changed.
2 participants