Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server-netbox): handle nested prefixes #5908

Merged
merged 2 commits into from Sep 21, 2021

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Sep 15, 2021

See xoa-support#4018

When assigning prefixes to VMs, always pick the smallest prefix that the IP
matches

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can rebase your PR and merge it.

See xoa-support#4018

When assigning prefixes to VMs, always pick the smallest prefix that the IP
matches
@pdonias pdonias force-pushed the pierre-netbox-match-smallest-prefix branch from 5af6353 to a10be17 Compare September 21, 2021 07:55
@pdonias pdonias merged commit 0966efb into master Sep 21, 2021
@pdonias pdonias deleted the pierre-netbox-match-smallest-prefix branch September 21, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants