Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/health): filter duplicated MAC addresses by running VMs #5917

Merged
merged 4 commits into from Sep 24, 2021

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Sep 24, 2021

See xoa-support#4054

Screenshots

Capture_2021-09-27_11:49:44

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA self-assigned this Sep 24, 2021
@MathieuRA MathieuRA changed the title feat(xo-web/dashboard/healt): filter duplicated mac addresses by running vms feat(xo-web/dashboard/health): filter duplicated mac addresses by running vms Sep 24, 2021
@MathieuRA MathieuRA changed the title feat(xo-web/dashboard/health): filter duplicated mac addresses by running vms feat(xo-web/health): filter duplicated mac addresses by running vms Sep 24, 2021
@MathieuRA MathieuRA changed the title feat(xo-web/health): filter duplicated mac addresses by running vms feat(xo-web/health): filter duplicated MAC addresses by running VMs Sep 24, 2021
packages/xo-web/src/xo-app/dashboard/health/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/dashboard/health/index.js Outdated Show resolved Hide resolved
@pdonias pdonias merged commit 919d118 into master Sep 24, 2021
@pdonias pdonias deleted the filterMacAddress branch September 24, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants