Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backups): really delete vhd/xva when deleting backups #6081

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

fbeauchamp
Copy link
Collaborator

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp force-pushed the florent-deleting_delta_backup branch 2 times, most recently from 5057dc8 to 98c0de9 Compare January 6, 2022 15:52
@fbeauchamp
Copy link
Collaborator Author

Why did I let from afterBackup of MixinBackup and did I not create a scheduledCleanVm method in RemoteAdapter

  • the declaration of cleanVm in MIxinBackup will be duplicated, since it's still needed by beforeBackup and will be needed by scheduledCleanVm
  • afterBackup needs lockFile, which is not needed for deleteVm
  • the config for disableMergeWorker does not seems easily accessible from RemoteAdapter
  • deporting this to a MergeWorker means the backup will not really deleted when the UI mark it as done
  • without Merge, the main cost of the cleanVm script will be the deleting, we should be quite fast for vhdFile ( but slow for vhdDirectory).

Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, this PR contains 3 different fixes (or two fixes and a feature/chore), I would expect 3 separate commits.

@julien-f julien-f changed the title fix(@xen-orchestra/backups): really delete vhd/xva when deleting backups fix(backups): really delete vhd/xva when deleting backups Jan 16, 2022
@julien-f julien-f force-pushed the florent-deleting_delta_backup branch from 23a5dc6 to f3941b0 Compare January 19, 2022 09:37
@julien-f julien-f force-pushed the florent-deleting_delta_backup branch from f3941b0 to d0ea6db Compare January 19, 2022 09:44
@julien-f julien-f force-pushed the florent-deleting_delta_backup branch from d0ea6db to 29aeb35 Compare January 19, 2022 09:45
@julien-f julien-f marked this pull request as ready for review January 19, 2022 09:45
@julien-f julien-f merged commit f6a2b50 into master Jan 19, 2022
@julien-f julien-f deleted the florent-deleting_delta_backup branch January 19, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants