Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/dashboard/health): show pools with no default SR #6083

Merged
merged 7 commits into from
Jan 26, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Jan 7, 2022

See zammad#4640

Screenshot

Capture d’écran de 2022-01-07 14-31-47

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to mention the packages in the commit context.

packages/xo-web/src/xo-app/dashboard/health/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/dashboard/health/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/dashboard/health/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/dashboard/health/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA self-assigned this Jan 24, 2022
@MathieuRA MathieuRA changed the title feat(Dashboard/Health): show pools with no default SR feat(xo-web/dashboard/health): show pools with no default SR Jan 24, 2022
@pdonias pdonias merged commit 2e8e252 into master Jan 26, 2022
@pdonias pdonias deleted the noDefaultSrOnPool branch January 26, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants