Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backups/_MixinBackupWriter#afterBackup): execute merge on S3 #6095

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Jan 18, 2022

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp mentioned this pull request Jan 18, 2022
8 tasks
@@ -20,6 +20,7 @@
> Users must be able to say: “I had this issue, happy to know it's fixed”

- [Backup] Detect and clear orphan merge states, fix `ENOENT` errors (PR [#6087](https://github.com/vatesfr/xen-orchestra/pull/6087))
- [Backup] Ensure merges are also executed after backup on S3 (PR [#6095](https://github.com/vatesfr/xen-orchestra/pull/6095)), maintaining the size of the vhd size under control
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format is weird, the PR mention should be at the end.

Any refs for this PR? (issues, forum, etc)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's from https://xcp-ng.org/forum/topic/5256/s3-backup-try-it/119 , but I don't know how to target a specific post

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right-click on the post time to get the URL of the specific post

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@julien-f julien-f changed the title fix(backup): ensure merge are executed after backup on S3 fix(backups/_MixinBackupWriter#afterBackup): execute merge on S3 Jan 18, 2022
@julien-f julien-f merged commit c10601d into master Jan 18, 2022
@julien-f julien-f deleted the fix_afterBackup_cleanVm branch January 18, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants