Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server): invalid arguments passed to VM_destroy #6119

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Feb 16, 2022

See https://xcp-ng.org/forum/topic/5569

Fixes #6124

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@pdonias pdonias requested review from MathieuRA and Rajaa-BARHTAOUI and removed request for MathieuRA March 16, 2022 10:50
@pdonias pdonias marked this pull request as ready for review March 16, 2022 15:20
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
@pdonias pdonias requested a review from julien-f March 17, 2022 13:34
@julien-f julien-f merged commit 3f07f7e into master Mar 17, 2022
@julien-f julien-f deleted the pierre-fix-vm-destroy branch March 17, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant delete default templates "incorrect state"
3 participants