Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server/api/sr, xo-web/dashboard/health): list all coalesce VDIs #6120

Merged
merged 14 commits into from
Feb 25, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Feb 17, 2022

See zammad#5224

Screenshot

Capture d’écran de 2022-02-23 12-02-16

Capture d’écran du 2022-02-23 14-42-01

Capture d’écran du 2022-02-23 14-21-25

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA changed the title Wip feat(Dashboard/Health): List all coalesce vdis feat(Dashboard/Health): List all coalesce vdis Feb 17, 2022
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/dashboard/health/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/dashboard/health/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/dashboard/health/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include the card header in the screenshot so that it's easier to understand what the feature does just by looking at the screenshot.

packages/xo-web/src/xo-app/dashboard/health/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/dashboard/health/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/dashboard/health/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/dashboard/health/index.js Outdated Show resolved Hide resolved
@julien-f julien-f self-requested a review February 23, 2022 09:09
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI changed the title feat(Dashboard/Health): List all coalesce vdis feat(xo-server/sr, xo-web/dashboard/health): list all coalesce VDIs Feb 24, 2022
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI changed the title feat(xo-server/sr, xo-web/dashboard/health): list all coalesce VDIs feat(xo-server/api/sr, xo-web/dashboard/health): list all coalesce VDIs Feb 24, 2022
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI requested review from julien-f and removed request for julien-f February 24, 2022 12:59
@julien-f julien-f merged commit 0975863 into master Feb 25, 2022
@julien-f julien-f deleted the listVdiCoale branch February 25, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants