Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-web/new/SR/NFS): disable "No selected value" path option #6137

Merged
merged 9 commits into from
Mar 23, 2022
Merged

fix(xo-web/new/SR/NFS): disable "No selected value" path option #6137

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f78b682
fix(xo-web/new/sr): fix sr.probeNfsExists no selected value
MathieuRA Mar 9, 2022
05338ee
changelog
MathieuRA Mar 9, 2022
a69e237
Update packages/xo-web/src/xo-app/new/sr/index.js
MathieuRA Mar 10, 2022
de51ba3
changelog
MathieuRA Mar 21, 2022
14dcc51
remove console.og
MathieuRA Mar 21, 2022
8f2cf96
Update CHANGELOG.unreleased.md
MathieuRA Mar 21, 2022
25e897d
disable option
MathieuRA Mar 23, 2022
4790096
Merge branch 'fixSrNfsProb' of github.com:vatesfr/xen-orchestra into …
MathieuRA Mar 23, 2022
b1ff3fa
Merge branch 'master' into fixSrNfsProb
pdonias Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
> Users must be able to say: “I had this issue, happy to know it's fixed”

- [Rolling Pool Update] Don't fail if `load-balancer` plugin is missing (Starter and Enterprise plans)
- [New sr] Fix `sr.probeNfsExists` with value as "No selected value" [#5991](https://github.com/vatesfr/xen-orchestra/issues/5991)(PR [#6137](https://github.com/vatesfr/xen-orchestra/pull/6137))
pdonias marked this conversation as resolved.
Show resolved Hide resolved

### Packages to release

Expand All @@ -33,3 +34,4 @@
- xen-api major
- vhd-cli minor
- xo-server patch
- xo-web patch
5 changes: 4 additions & 1 deletion packages/xo-web/src/xo-app/new/sr/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,9 @@ export default class New extends Component {
}

_handleSrPathSelection = async path => {
if (path === '') {
return
}
pdonias marked this conversation as resolved.
Show resolved Hide resolved
const { server } = this.refs
const { host } = this.state

Expand Down Expand Up @@ -696,7 +699,7 @@ export default class New extends Component {
ref='path'
required
>
<option value={null}>{formatMessage(messages.noSelectedValue)}</option>
<option value=''>{formatMessage(messages.noSelectedValue)}</option>
pdonias marked this conversation as resolved.
Show resolved Hide resolved
pdonias marked this conversation as resolved.
Show resolved Hide resolved
{map(paths, (item, key) => (
<option key={key} value={item.path}>
{item.path}
Expand Down