feat(xo-web,xo-server): implement ISO import #6180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeauchamp
force-pushed
the
feat_import_iso
branch
5 times, most recently
from
3b0b036
to
25fb509
Compare
fbeauchamp
changed the title
fbeauchamp
force-pushed
the
feat_import_iso
branch
from
23a8b03
to
d152470
Compare
fbeauchamp
force-pushed
the
feat_import_iso
branch
from
7eb01eb
to
e54b968
Compare
MathieuRA
requested changes
Apr 22, 2022
MathieuRA
approved these changes
Apr 22, 2022
pdonias
requested changes
Apr 22, 2022
| @@ -1584,7 +1584,7 @@ const messages = { | |||
| // ---- Disk import --- | |||
| diskImportFailed: 'Disk import failed', | |||
| diskImportSuccess: 'Disk import success', | |||
| dropDisksFiles: 'Drop VMDK or VHD files here to import disks.', | |||
| dropDisksFiles: 'Drop ISO, VMDK or VHD files here to import disks.', | |||
There was a problem hiding this comment.
Other languages need to be updated too.
|
|
||
| return ( | ||
| <ReactDropzone | ||
| activeClassName={styles.activeDropzone} | ||
| className={styles.dropzone} | ||
| multiple={multiple} | ||
| onDrop={onDrop} | ||
| accept={accept} |
| @@ -108,12 +108,16 @@ const DiskImport = decorate([ | |||
| <Row> | |||
| <LabelCol>{_('importToSr')}</LabelCol> | |||
| <InputCol> | |||
| <SelectSr onChange={effects.onChangeSr} required value={sr} /> | |||
| <SelectSr onChange={effects.onChangeSr} required value={sr} allowIsoSr /> | |||
There was a problem hiding this comment.
Why don't you pass predicate={isSrWritableOrIso} instead of handling a rare case in the component itself?
fbeauchamp
force-pushed
the
feat_import_iso
branch
from
4331d10
to
0279dbd
Compare
pdonias
approved these changes
Apr 22, 2022
julien-f
reviewed
Apr 25, 2022
julien-f
reviewed
Apr 27, 2022
fbeauchamp
force-pushed
the
feat_import_iso
branch
from
7c59a93
to
0279dbd
Compare
julien-f
changed the title
|
it would be really nice to have the import possible via URL also. Like it is already possible with virtual machines |
|
@prononext Now available in the REST API: https://xen-orchestra.com/blog/xen-orchestra-5-73/#%F0%9F%93%A1-rest-api-iso-import |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
Fixes #007orSee xoa-support#42)CHANGELOG.unreleased.md:${name} v${new version})cron/parse.spec.js)xo-serverAPI changes, the corresponding test has been added to/updated onxo-server-testProcess
WiP:(Work in Progress) if not ready to be mergedFrom the Four Agreements: