Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server/Rolling Pool Update/_xcpUpdate): handle undefined hosts #6186

Merged
merged 4 commits into from Apr 13, 2022

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Apr 12, 2022

Fixes #6170
Introduced by e7f9111

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@olivierlambert
Copy link
Member

Does it also fix the issue if you try to update from "Install pool patches" button?

@pdonias
Copy link
Member Author

pdonias commented Apr 12, 2022

Yes.

@pdonias pdonias requested a review from ByScripts April 13, 2022 07:24
@pdonias pdonias merged commit 3f1c41a into master Apr 13, 2022
@pdonias pdonias deleted the pierre-fix-rpu branch April 13, 2022 11:22
@rauly1994
Copy link

since i'm new to xen server. in this case. what would i need to do in order to fix the issue. is there an update i need to run?

@olivierlambert
Copy link
Member

If you are using XOA, just click on "update" button in the XOA updater section.
If you are using XO from the sources, follow the doc: https://xen-orchestra.com/docs/installation.html#updating

julien-f added a commit that referenced this pull request May 9, 2022
Introduced by 3f1c41a

Fixes zammad#6819 zammad#6781 zammad#6827

In #6186 the behavior was changed to always pass hosts, which broke the pool wide detection.
julien-f added a commit that referenced this pull request May 12, 2022
Introduced by 3f1c41a

Fixes zammad#6819 zammad#6781 zammad#6827

In #6186 the behavior was changed to always pass hosts, which broke the pool wide detection.
julien-f added a commit that referenced this pull request May 12, 2022
Introduced by 3f1c41a

Fixes zammad#6819 zammad#6781 zammad#6827

In #6186 the behavior was changed to always pass hosts, which broke the pool wide detection.
julien-f added a commit that referenced this pull request May 12, 2022
Introduced by 3f1c41a

Fixes zammad#6819 zammad#6781 zammad#6827

In #6186 the behavior was changed to always pass hosts, which broke the pool wide detection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting rollingUpdate gives "cannot read properties of undefined (reading 'sort')" error
5 participants