Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fs/s3): fix stream writing support with Object Lock enabled #6190

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

ByScripts
Copy link
Contributor

@ByScripts ByScripts commented Apr 14, 2022

Fix for: aws/aws-sdk-js-v3#2673

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

Copy link
Collaborator

@fbeauchamp fbeauchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove the WIp in the title
  • update the changelog
  • does it fixes delta or delta / full / pool

@ByScripts ByScripts changed the title WiP: fix(fs/s3): Fix Delta backup when S3 Object Lock is enabled fix(fs/s3): Fix failure when sending a backup to S3 with Object Lock enabled Apr 15, 2022
CHANGELOG.unreleased.md Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@julien-f julien-f changed the title fix(fs/s3): Fix failure when sending a backup to S3 with Object Lock enabled fix(fs/s3): fix stream support with Object Lock enabled Apr 21, 2022
@julien-f julien-f changed the title fix(fs/s3): fix stream support with Object Lock enabled fix(fs/s3): fix stream writing support with Object Lock enabled Apr 21, 2022
@julien-f julien-f merged commit 854ae0f into master Apr 26, 2022
@julien-f julien-f deleted the fix_s3_backup_object_lock branch April 26, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants