Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mixins/HttpProxy): HTTP/HTTP CONNECT proxy #6201

Merged
merged 18 commits into from
Apr 28, 2022
Merged

feat(mixins/HttpProxy): HTTP/HTTP CONNECT proxy #6201

merged 18 commits into from
Apr 28, 2022

Conversation

julien-f
Copy link
Member

@julien-f julien-f commented Apr 23, 2022

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@julien-f julien-f marked this pull request as ready for review April 27, 2022 10:04
@xen-orchestra/mixins/HttpProxy.js Outdated Show resolved Hide resolved
@xen-orchestra/mixins/docs/HttpProxy.md Outdated Show resolved Hide resolved
packages/xen-api/src/_parseUrl.js Outdated Show resolved Hide resolved
@julien-f julien-f merged commit 3ecf099 into master Apr 28, 2022
@julien-f julien-f deleted the http-proxy branch April 28, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants