Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server/xo-web/pool): avoid RPU/ host reboot, shutdown / host agent reboot during backup #6232

Merged
merged 19 commits into from
May 30, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented May 12, 2022

See zammad#5377

Screenshot

Capture d’écran de 2022-05-12 15-59-01

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA changed the title WiP: avoid RPU during backup feat(xo-server/xo-web/RPU): avoid RPU during backup May 12, 2022
@MathieuRA MathieuRA changed the title feat(xo-server/xo-web/RPU): avoid RPU during backup feat(xo-server/xo-web/pool): avoid RPU during backup May 12, 2022
@MathieuRA MathieuRA requested review from fbeauchamp and removed request for fbeauchamp May 12, 2022 14:09
@MathieuRA MathieuRA requested a review from fbeauchamp May 16, 2022 08:13
@MathieuRA MathieuRA changed the title feat(xo-server/xo-web/pool): avoid RPU during backup feat(xo-server/xo-web/pool): avoid RPU/ host reboot, shutdown during backup May 17, 2022
@MathieuRA MathieuRA changed the title feat(xo-server/xo-web/pool): avoid RPU/ host reboot, shutdown during backup feat(xo-server/xo-web/pool): avoid RPU/ host reboot, shutdown / host agent reboot during backup May 17, 2022
@MathieuRA MathieuRA requested a review from fbeauchamp May 17, 2022 13:20
packages/xo-server/src/api/pool.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/api/pool.mjs Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from fbeauchamp May 18, 2022 08:59
packages/xo-server/src/api/pool.mjs Outdated Show resolved Hide resolved
Co-authored-by: Florent BEAUCHAMP <florent.beauchamp@vates.fr>
@fbeauchamp fbeauchamp requested a review from pdonias May 18, 2022 13:36
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MathieuRA Should I review xo-server too?

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
@MathieuRA
Copy link
Member Author

@MathieuRA Should I review xo-server too?

I am going to assign @julien-f for xo-server

@MathieuRA MathieuRA requested a review from julien-f May 19, 2022 08:38
@MathieuRA MathieuRA requested a review from fbeauchamp May 23, 2022 12:14
@fbeauchamp fbeauchamp requested a review from pdonias May 24, 2022 12:05
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xo-web ok, not tested.

@pdonias pdonias requested a review from julien-f May 30, 2022 08:42
@julien-f julien-f merged commit 837b06e into master May 30, 2022
@julien-f julien-f deleted the preventFromRunningBackup branch May 30, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants