Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vhd-lib/VhdDirectory#writeChunkFilters): correctly overwrite chunk-filter.json #6235

Merged
merged 1 commit into from
May 13, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented May 13, 2022

  • writeChunkFilters would have crashed if filter file does not exists and we set a empty compression
  • it would not have updated the filter file if used with a fs implementation respecting fs permissions flags

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp requested a review from ByScripts May 13, 2022 07:53
@fbeauchamp fbeauchamp requested a review from julien-f May 13, 2022 07:55
- it would not have updated the filter file if used with a fs implementation respecting fs permissions flags
@julien-f julien-f changed the title fix(vhddirectory): better handling of filter file fix(vhd-lib/VhdDirectory#writeChunkFilters): correctly overwrite chunk-filter.json May 13, 2022
@julien-f julien-f merged commit 1a741e1 into master May 13, 2022
@julien-f julien-f deleted the fix_filter_file branch May 13, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants