Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server-backup-reports): show health check #6242

Merged
merged 3 commits into from
May 24, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented May 18, 2022

Screenshot

image

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp requested a review from MathieuRA May 19, 2022 12:53
@MathieuRA MathieuRA requested a review from julien-f May 19, 2022 14:45
@fbeauchamp fbeauchamp requested a review from julien-f May 23, 2022 13:48
@julien-f julien-f changed the title feat(Backup) : show healthcheck result in report feat(xo-server-backup-reports): show health check May 23, 2022
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, remove the draft status when you want me to merge.

@fbeauchamp fbeauchamp marked this pull request as ready for review May 24, 2022 12:19
@julien-f julien-f merged commit 5393d84 into master May 24, 2022
@julien-f julien-f deleted the feat_healthcheck_report branch May 24, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants