Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server/pool): disable scheduled job when starting RPU #6244

Merged
merged 9 commits into from
May 31, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented May 19, 2022

See zammad#5377, zammad#5333

Screenshot

Capture d’écran de 2022-05-24 11-07-17

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA changed the title Wip: feat(xo-server/pool): disable scheduled job when starting RPU feat(xo-server/pool): disable scheduled job when starting RPU May 24, 2022
@MathieuRA MathieuRA requested a review from fbeauchamp May 24, 2022 09:10
packages/xo-server/src/api/pool.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/api/pool.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from julien-f May 24, 2022 10:09
@julien-f julien-f requested review from julien-f and removed request for julien-f May 29, 2022 23:22
@pdonias pdonias requested review from fbeauchamp and removed request for julien-f May 30, 2022 13:53
@julien-f julien-f self-requested a review May 30, 2022 14:06
@julien-f julien-f merged commit 7a2005c into master May 31, 2022
@julien-f julien-f deleted the noBackupDuringRPU branch May 31, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants