Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/proxies): copy proxy URL #6287

Merged
merged 8 commits into from
Jun 27, 2022
Merged

feat(xo-web/proxies): copy proxy URL #6287

merged 8 commits into from
Jun 27, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Jun 13, 2022

Screenshot

Capture d’écran de 2022-06-15 11-29-09

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@julien-f
Copy link
Member

julien-f commented Jun 14, 2022

  • url can be undefined

@MathieuRA MathieuRA changed the title Wip: feat(xo-web/proxies): display proxy URL feat(xo-web/proxies): display proxy URL Jun 15, 2022
@MathieuRA MathieuRA requested review from Rajaa-BARHTAOUI and ByScripts and removed request for Rajaa-BARHTAOUI and ByScripts June 15, 2022 13:14
@MathieuRA MathieuRA self-assigned this Jun 22, 2022
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/proxies/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/proxies/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/proxies/index.js Show resolved Hide resolved
@MathieuRA MathieuRA changed the title feat(xo-web/proxies): display proxy URL feat(xo-web/proxies): copy proxy URL Jun 24, 2022
@MathieuRA MathieuRA requested a review from pdonias June 24, 2022 09:10
@pdonias pdonias merged commit cfc53c9 into master Jun 27, 2022
@pdonias pdonias deleted the proxy_token branch June 27, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants