Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xapi/VM_destroy): throw forbiddenOperation if operation blocked #6290

Merged
merged 7 commits into from
Jun 16, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Jun 14, 2022

Description

This small change will fix the force modal confirm for VM deletion.
See UI error checking

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA requested a review from julien-f June 15, 2022 08:29
@MathieuRA MathieuRA self-assigned this Jun 15, 2022
@xen-orchestra/xapi/vm.js Outdated Show resolved Hide resolved
@xen-orchestra/xapi/vm.js Outdated Show resolved Hide resolved
@xen-orchestra/xapi/vm.js Outdated Show resolved Hide resolved
julien-f added a commit that referenced this pull request Jun 16, 2022
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
@MathieuRA MathieuRA requested a review from julien-f June 16, 2022 11:40
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
@julien-f julien-f changed the title fix(xapi/vm): throw forbiddenOperation on blockedOperation fix(xapi/VM_destroy): throw forbiddenOperation if operation blocked Jun 16, 2022
@julien-f julien-f merged commit 89313de into master Jun 16, 2022
@julien-f julien-f deleted the fix_blocked_op_del_vm branch June 16, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants