Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mixins/SslCertificate): Let's Encrypt support #6320

Merged
merged 14 commits into from
Jul 28, 2022
Merged

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Jul 12, 2022

Test recipe

  • create a xo, listenning to port 80 and 443
  • expose this server to the internet
  • ssl certificate should be broken ( missing/self signed)
  • add certDomain = 'domainname.xxx' to the https part of the config
  • reload the server
  • load the https page
  • it should have a valid certificate after a few seconds
  • next loading should not re compute a certificate
  • accessing XO through another domain (localhost) should show a self signed certificate
  • accessing XO through the IP shoul show a self seigned certifiate
  • redirect to https shouldn't redirect challenge

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp requested a review from julien-f July 18, 2022 08:40
@julien-f julien-f marked this pull request as draft July 18, 2022 08:44
julien-f added a commit that referenced this pull request Jul 18, 2022
Fixes zammad#8073

Related to #6320

- brings `no_proxy` supports
- implicit supports for other libs
@xen-orchestra/mixins/SslCertificate.mjs Outdated Show resolved Hide resolved
@xen-orchestra/mixins/SslCertificate.mjs Outdated Show resolved Hide resolved
@xen-orchestra/mixins/SslCertificate.mjs Outdated Show resolved Hide resolved
@xen-orchestra/mixins/SslCertificate.mjs Outdated Show resolved Hide resolved
@xen-orchestra/mixins/SslCertificate.mjs Outdated Show resolved Hide resolved
@xen-orchestra/mixins/SslCertificate.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/index.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/index.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/index.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/index.mjs Outdated Show resolved Hide resolved
julien-f added a commit that referenced this pull request Jul 18, 2022
Fixes zammad#8073

Related to #6320

- brings `no_proxy` supports
- implicit supports for other libs
julien-f added a commit that referenced this pull request Jul 18, 2022
Fixes zammad#8073

Related to #6320

- brings `no_proxy` supports
- implicit supports for other libs
julien-f added a commit that referenced this pull request Jul 20, 2022
Fixes zammad#8073

Related to #6320

- brings `no_proxy` supports
- implicit supports for other libs
@fbeauchamp fbeauchamp force-pushed the feat_lets_encrypt branch 3 times, most recently from 33ba1dc to 484c69b Compare July 20, 2022 18:41
@fbeauchamp fbeauchamp requested a review from julien-f July 22, 2022 06:14
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp marked this pull request as ready for review July 22, 2022 14:19
@fbeauchamp fbeauchamp force-pushed the feat_lets_encrypt branch 2 times, most recently from 8b109df to 704201c Compare July 22, 2022 14:22
@fbeauchamp fbeauchamp requested a review from julien-f July 25, 2022 06:35
@fbeauchamp fbeauchamp requested a review from julien-f July 26, 2022 08:30
@julien-f julien-f changed the title feat(web): automagically acquire and renew let's encrypt ssl certificate feat(mixins/SslCertificate): Let's Encrypt support Jul 26, 2022
@xen-orchestra/mixins/SslCertificate.mjs Outdated Show resolved Hide resolved
@xen-orchestra/mixins/SslCertificate.mjs Show resolved Hide resolved
packages/xo-server/src/index.mjs Outdated Show resolved Hide resolved
@xen-orchestra/mixins/SslCertificate.mjs Outdated Show resolved Hide resolved
@julien-f julien-f merged commit 10c77ba into master Jul 28, 2022
@julien-f julien-f deleted the feat_lets_encrypt branch July 28, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants