Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/home/vm): show error toaster when deleting VMs failed #6323

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Jul 18, 2022

Screenshots

  • Deleting 1 VM with protection enabled from the home page:
    Capture_2022-07-18_15:52:47
  • Deleting multiple VMs from the home page and some of them have the protection enabled:
    Capture_2022-07-18_15:52:28

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@pdonias pdonias requested a review from MathieuRA July 18, 2022 13:50
Copy link
Member

@MathieuRA MathieuRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add screenshot of the blocked operation modal ?

@MathieuRA MathieuRA requested review from MathieuRA and Rajaa-BARHTAOUI and removed request for MathieuRA July 19, 2022 12:11
@pdonias
Copy link
Member Author

pdonias commented Jul 19, 2022

@MathieuRA When you only select one VM, deleteVms falls back to the deleteVm method that shows a modal when the operation is blocked and allows you to force it. I edited the PR description to clarify that.

@pdonias pdonias merged commit 11e09e1 into master Jul 21, 2022
@pdonias pdonias deleted the pierre-error-protected-vm branch July 21, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants