Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/storage/NFS): ability to specify subdirectory #6425

Merged
merged 5 commits into from
Sep 26, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Sep 16, 2022

Fixes #3919

Recipe

Create directory:

sudo mkdir -p /tmp/srv/nfs/test

Update /etc/exports:

...
/tmp/srv/nfs        *(rw,no_root_squash,sync,no_subtree_check)

Refresh the current NFS exports:

sudo exportfs -ra

Confirm your folder is now exported:

showmount -e localhost

You are ready to test the feature using the subdirectory: test

Screenshot

Capture d’écran de 2022-09-15 17-07-43

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA self-assigned this Sep 16, 2022
@pdonias pdonias requested review from Rajaa-BARHTAOUI and removed request for pdonias September 21, 2022 08:39
@MathieuRA MathieuRA requested review from pdonias and removed request for Rajaa-BARHTAOUI September 26, 2022 08:41
@fbeauchamp
Copy link
Collaborator

fbeauchamp commented Sep 26, 2022

tests done

@pdonias pdonias changed the title feat(xo-web/storage/nfs): possibility to use subdirectoy feat(xo-web/storage/NFS): ability to specify subdirectory Sep 26, 2022
@pdonias pdonias merged commit 74c8d56 into master Sep 26, 2022
@pdonias pdonias deleted the nfsSubdirectory branch September 26, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Append NFS SR Path
3 participants