Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/SR): fix "VDIs to coalesce" in SR advanced tab #6429

Merged
merged 4 commits into from
Sep 21, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Sep 19, 2022

See Xcp-ng-forum#6334

Introduced by a9c1239

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA self-assigned this Sep 19, 2022
Copy link
Collaborator

@fbeauchamp fbeauchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoud add to the PR : introduced by a9c1239

@julien-f
Copy link
Member

In the future, don't use Markdown or a link for the introduced by as it's not supported in the commit message itself, just use plain text.

Also, it's easier if you put this in the message of your first commit as it will appear directly in the message of the commit that will be merged by GitHub, it avoids me to copy/paste it 🙂

@pdonias pdonias changed the title fix(xo-web/sr): fix vdi to coalesce in sr advanced tab fix(xo-web/SR): fix "VDIs to coalesce" in SR advanced tab Sep 21, 2022
@pdonias pdonias merged commit f1ab625 into master Sep 21, 2022
@pdonias pdonias deleted the mathieu/fixSrAdvancedCoalesce branch September 21, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants