Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server): ignore disabled remotes when running VM backup #6430

Merged
merged 6 commits into from
Sep 26, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Sep 19, 2022

from #6374

Test recipe

  • create a backup with at least two remote
  • run backup
  • it should succeed
  • disable a backup
  • rerun backup
  • it should succeed with a warning in the log about the disabled remote

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp force-pushed the fix_remote_disabled_stop_backups branch from 8d1d11a to 297f309 Compare September 19, 2022 16:04
@MathieuRA MathieuRA removed their request for review September 20, 2022 13:02
Copy link
Member

@MathieuRA MathieuRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to mention xo-server in the PR title. (xo-server/backup)
Tested ✅

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: Mathieu <70369997+MathieuRA@users.noreply.github.com>
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
@fbeauchamp fbeauchamp changed the title fix(backup): don't stop backup on remote disabled if at least one remote is ok fix(xo-sever/backup): don't stop backup on remote disabled if at least one remote is ok Sep 26, 2022
@fbeauchamp fbeauchamp changed the title fix(xo-sever/backup): don't stop backup on remote disabled if at least one remote is ok fix(xo-server/backup): don't stop backup on remote disabled if at least one remote is ok Sep 26, 2022
@julien-f julien-f changed the title fix(xo-server/backup): don't stop backup on remote disabled if at least one remote is ok fix(xo-server): ignore disabled remotes when running VM backup Sep 26, 2022
@julien-f julien-f merged commit 2d6b827 into master Sep 26, 2022
@julien-f julien-f deleted the fix_remote_disabled_stop_backups branch September 26, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants