Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@xen-orchestra/fs): use aes 256 gcm encryption algorithm #6447

Merged
merged 10 commits into from
Oct 17, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Oct 6, 2022

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp force-pushed the use_encryption_aes_gcm branch 2 times, most recently from 263962d to dc18a37 Compare October 7, 2022 08:55
@fbeauchamp fbeauchamp marked this pull request as ready for review October 7, 2022 09:05
@xen-orchestra/fs/src/_encryptor.js Outdated Show resolved Hide resolved
@xen-orchestra/fs/src/_encryptor.js Show resolved Hide resolved
@xen-orchestra/fs/src/fs.spec.js Outdated Show resolved Hide resolved
@xen-orchestra/fs/src/_encryptor.js Outdated Show resolved Hide resolved
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me know if I should merge it.

@fbeauchamp
Copy link
Collaborator Author

LGTM, let me know if I should merge it.

yes please, merge it

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
fbeauchamp and others added 4 commits October 17, 2022 11:28
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
@julien-f julien-f merged commit 05161bd into master Oct 17, 2022
@julien-f julien-f deleted the use_encryption_aes_gcm branch October 17, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants