Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backups): use NBD to export VDIs when possible #6461

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Oct 11, 2022

screenshot

VM:
image
host:
image
pool
image

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp changed the base branch from master to feat_nbd_client October 11, 2022 14:48
@fbeauchamp fbeauchamp force-pushed the feat_nbd_client branch 2 times, most recently from da72b80 to cfeb2c0 Compare October 11, 2022 15:33
Base automatically changed from feat_nbd_client to master October 12, 2022 12:46
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp force-pushed the feat_use_nbd_client_backup branch 2 times, most recently from e264872 to 58da02a Compare October 19, 2022 14:43
@fbeauchamp fbeauchamp marked this pull request as ready for review October 19, 2022 15:01
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@julien-f
Copy link
Member

Rebase this PR and request a review when you want me to merge 🙂

@julien-f julien-f changed the title feat(@xen-orchestra/backups): use nbd to transfer data when possible feat(backups): use NBD to export VDIs when possible Oct 27, 2022
@julien-f julien-f merged commit 7ede6bd into master Oct 27, 2022
@julien-f julien-f deleted the feat_use_nbd_client_backup branch October 27, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants