Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pool): added tooltip for no support icon #6505

Merged
merged 8 commits into from
Nov 4, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

> Users must be able to say: “I had this issue, happy to know it's fixed”

- [Pool] Added tooltip for `no support` icon (PR [#6505](https://github.com/vatesfr/xen-orchestra/pull/6505))
MathieuRA marked this conversation as resolved.
Show resolved Hide resolved

### Packages to release

> When modifying a package, add it here with its release type.
Expand All @@ -27,4 +29,6 @@

<!--packages-start-->

- xo-web patch

<!--packages-end-->
1 change: 1 addition & 0 deletions packages/xo-web/src/common/intl/messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,7 @@ const messages = {

// ----- Pool general -----
earliestExpirationDate: 'Earliest expiration: {dateString}',
poolNoSupport: 'No support available for this pool',
pdonias marked this conversation as resolved.
Show resolved Hide resolved
poolPartialSupport:
'Only {nHostsLicense, number} host{nHostsLicense, plural, one {} other {s}} under license on {nHosts, number} host{nHosts, plural, one {} other {s}}. This means this pool is not supported at all until you license all its hosts.',
poolTitleRamUsage: 'Pool RAM usage:',
Expand Down
6 changes: 5 additions & 1 deletion packages/xo-web/src/xo-app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,11 @@ export const ICON_POOL_LICENSE = {
<Icon icon='alarm' className='text-warning' />
</Tooltip>
),
any: () => <Icon icon='alarm' className='text-danger' />,
any: () => (
<Tooltip content={_('poolNoSupport')}>
<Icon icon='alarm' className='text-danger' />
</Tooltip>
),
pdonias marked this conversation as resolved.
Show resolved Hide resolved
}

@routes('home', {
Expand Down