Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/proxy): register an existing proxy #6556

Merged
merged 13 commits into from
Nov 29, 2022
Merged

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Nov 25, 2022

Screenshot

Capture d’écran de 2022-11-28 16-09-10
Capture d’écran de 2022-11-29 11-23-59

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA self-assigned this Nov 25, 2022
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Show resolved Hide resolved
packages/xo-web/src/xo-app/proxies/connect-proxy-modal.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/proxies/connect-proxy-modal.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/proxies/index.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Show resolved Hide resolved
packages/xo-web/src/xo-app/proxies/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
@julien-f julien-f changed the title feat(xo-web/proxy): Connect to an existing proxy feat(xo-web/proxy): register an existing proxy Nov 28, 2022
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not tested!

@julien-f julien-f merged commit 552a9c7 into master Nov 29, 2022
@julien-f julien-f deleted the mathieu/connectProxy branch November 29, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants