-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(xo-server): import VM from esxi #6595
Conversation
40b5cb1
to
c480399
Compare
throw error | ||
} | ||
if(res.headers.raw()['set-cookie']){ | ||
this.#cookies = res.headers.raw()['set-cookie'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use set-cookie-parser
, see https://github.com/vatesfr/xen-orchestra/blob/master/packages/xo-server/src/xo-mixins/proxies.mjs#L453
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't succeed in making it work with cookie parser, I checked the code and it do exactmy 2 authentication : one for the soap query, and one for the download queries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or you can use:
headers.cookie = res.headers.raw()['set-cookie'].map(cookie => cookie.split(';')[0]).join('; '))
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
Check list
Fixes #007
orSee xoa-support#42
)CHANGELOG.unreleased.md
:${name} v${new version}
)cron/parse.spec.js
)xo-server
API changes, the corresponding test has been added to/updated onxo-server-test
Process
WiP:
(Work in Progress) if not ready to be mergedFrom the Four Agreements: