Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/recipes): static network config for k8s recipe #6598

Merged
merged 23 commits into from
Jan 24, 2023

Conversation

ggunullu
Copy link
Contributor

@ggunullu ggunullu commented Dec 30, 2022

image

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@ggunullu ggunullu marked this pull request as ready for review January 2, 2023 08:34
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/hub/recipes/recipe.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/hub/recipes/recipe-form.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/hub/recipes/recipe-form.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/hub/recipes/recipe.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/hub/recipes/recipe.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/hub/recipes/recipe.js Outdated Show resolved Hide resolved
@ggunullu ggunullu requested a review from pdonias January 9, 2023 09:02
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
@pdonias pdonias requested review from Rajaa-BARHTAOUI and removed request for pdonias January 9, 2023 09:41
ggunullu and others added 3 commits January 11, 2023 11:04
Co-authored-by: rajaa-b <rajaa.barhtaoui@gmail.com>
Co-authored-by: rajaa-b <rajaa.barhtaoui@gmail.com>
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to add the screenshot to the PR description

packages/xo-web/src/xo-app/hub/recipes/recipe-form.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/hub/recipes/recipe-form.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the remaining comments?

ggunullu and others added 2 commits January 12, 2023 11:26
Co-authored-by: rajaa-b <rajaa.barhtaoui@gmail.com>
Co-authored-by: rajaa-b <rajaa.barhtaoui@gmail.com>
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI removed their request for review January 12, 2023 10:33
@ggunullu
Copy link
Contributor Author

I fixed the issue.

If you want to test the feature:

  1. Fulfill the recipe form with static addresses for the cluster's nodes.
  2. Wait for the VMs to be created with the cloud-init config (that step can be quite long, don´t be surprised).
  3. Check in the VMs general tab that the IP addresses are correctly configured.
  4. Connect to the master node and execute the command kubectl get pods --all-namespaces.
  5. You must have a number of flannel pods equals to the total number of nodes.
  6. Same for the number of proxy pods.
  7. All pods must be in running state

@ggunullu ggunullu requested a review from pdonias January 20, 2023 15:25
@pdonias
Copy link
Member

pdonias commented Jan 24, 2023

@ggunullu Don't you want to add a Changelog entry for this?

@ggunullu
Copy link
Contributor Author

ggunullu commented Jan 24, 2023

@ggunullu Don't you want to add a Changelog entry for this?

I thought I had added a changelog entry, I can see it right now in vscode 🤔

EDIT: There is already a xo-web minor

@pdonias pdonias changed the title feat(xo-web): static network config for k8s recipe feat(xo-web/recipes): static network config for k8s recipe Jan 24, 2023
@pdonias pdonias merged commit fedbdba into master Jan 24, 2023
@pdonias pdonias deleted the gab-k8s-update_recipe branch January 24, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants