Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/network): NBD option #6646

Merged
merged 13 commits into from
Jan 30, 2023
Merged

feat(xo-web/network): NBD option #6646

merged 13 commits into from
Jan 30, 2023

Conversation

ggunullu
Copy link
Contributor

@ggunullu ggunullu commented Jan 30, 2023

Screenshots

image
image
image

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

Copy link
Member

@MathieuRA MathieuRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • PR title must start with feat(xo-web/network): ....
  • In the PR description, add ### Screenshots before adding screenshots.
  • Add CHANGELOG.unrelease.md entry.

packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/new/network/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-network.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/new/network/index.js Outdated Show resolved Hide resolved
@julien-f julien-f changed the title feat(xo-server/network): NBD option (frontend) feat(xo-web/network): NBD option Jan 30, 2023
@pdonias pdonias removed their request for review January 30, 2023 10:36
@MathieuRA MathieuRA requested review from pdonias and removed request for MathieuRA January 30, 2023 13:29
CHANGELOG.unreleased.md Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-network.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-network.js Outdated Show resolved Hide resolved
@ggunullu ggunullu requested a review from pdonias January 30, 2023 15:43
@MathieuRA MathieuRA removed the request for review from pdonias January 30, 2023 15:56
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-network.js Outdated Show resolved Hide resolved
@pdonias pdonias merged commit 5c0b29c into master Jan 30, 2023
@pdonias pdonias deleted the gab-network_nbd-frontend branch January 30, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants