Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/home): icon grouping #6655

Merged
merged 19 commits into from
Mar 15, 2023
Merged

feat(xo-web/home): icon grouping #6655

merged 19 commits into from
Mar 15, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Feb 3, 2023

Screenshots

Before

Capture d’écran de 2023-02-03 16-36-22

After

Capture d’écran de 2023-03-09 11-01-44
Capture d’écran de 2023-03-06 15-58-26

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA self-assigned this Feb 3, 2023
@MathieuRA MathieuRA changed the title Wip: feat(xo-web/home): icon grouping feat(xo-web/home): icon grouping Feb 6, 2023
@MathieuRA MathieuRA force-pushed the remove-tooltips-icon branch 2 times, most recently from a75f6f1 to eae1a60 Compare February 6, 2023 14:34
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to include the entry in the changelog.

packages/xo-web/src/common/bulk-icons.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/bulk-icons.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/bulk-icons.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/bulk-icons.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/home/host-item.js Show resolved Hide resolved
packages/xo-web/src/common/bulk-icons.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/bulk-icons.js Outdated Show resolved Hide resolved
packages/xo-web/src/index.scss Outdated Show resolved Hide resolved
packages/xo-web/src/index.scss Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/home/host-item.js Show resolved Hide resolved
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't forget to update the screenshots in the PR description.

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/home/host-item.js Show resolved Hide resolved
packages/xo-web/src/common/bulk-icons.js Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/bulk-icons.js Show resolved Hide resolved
packages/xo-web/src/xo-app/home/host-item.js Outdated Show resolved Hide resolved
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI requested review from pdonias and removed request for Rajaa-BARHTAOUI March 13, 2023 13:54
@MathieuRA
Copy link
Member Author

@pdonias Can you merge?

@pdonias pdonias merged commit aadc1bb into master Mar 15, 2023
@pdonias pdonias deleted the remove-tooltips-icon branch March 15, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants