Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(xo-server): implement Api for esxi migration UX #6662

Merged
merged 2 commits into from Feb 27, 2023
Merged

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Feb 8, 2023

review by commits

  • add new method exxi.listVms({host, user, password, sslVerify=true}) to api
    this will return
[
  {
    "id": "1",
    "nameLabel": "test_linux",
    "memory": 2147483648,
    "nCpus": 1,
    "guestToolsInstalled": false,
    "firmware": "bios",
    "powerState": "poweredOff",
    "storage": {
      "used": 216761,
      "free": 2318061568
    }
  },
  {
    "id": "2",
    "nameLabel": "test_small",
    "memory": 2147483648,
    "nCpus": 1,
    "guestToolsInstalled": false,
    "firmware": "bios",
    "powerState": "poweredOff",
    "storage": {
      "used": 10696,
      "free": 2586497520
    }
  },
  {
    "id": "4",
    "nameLabel": "test flo",
    "memory": 1073741824,
    "nCpus": 2,
    "guestToolsInstalled": false,
    "firmware": "bios",
    "powerState": "poweredOff",
    "storage": {
      "used": 6860092734,
      "free": 35570518969
    }
  },
  {
    "id": "8",
    "nameLabel": "damnsmalllinux",
    "memory": 268435456,
    "nCpus": 1,
    "guestToolsInstalled": false,
    "firmware": "bios",
    "powerState": "poweredOff",
    "storage": {
      "used": 154318782,
      "free": 553288173
    }
  },
  {
    "id": "9",
    "nameLabel": "miniubuntu",
    "memory": 2147483648,
    "nCpus": 3,
    "guestToolsInstalled": false,
    "firmware": "bios",
    "powerState": "poweredOn",
    "storage": {
      "used": 7720281547,
      "free": 8588887706
    }
  },
  {
    "id": "10",
    "nameLabel": "ubuntu2",
    "memory": 2147483648,
    "nCpus": 4,
    "guestToolsInstalled": false,
    "firmware": "bios",
    "powerState": "poweredOn",
    "storage": {
      "used": 6132889490,
      "free": 8555332434
    }
  },
  {
    "id": "20",
    "nameLabel": "windows",
    "memory": 2147483648,
    "nCpus": 1,
    "guestToolsInstalled": false,
    "firmware": "uefi",
    "powerState": "poweredOff",
    "storage": {
      "used": 1971,
      "free": 36662014449
    }
  }
]

memoy, used, and free are in bytes

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have:

  • rebased this branch on top of master
  • rewrote commit history
  • fixed a small issue in api/esxi.mjs

Please check everything is in order and I'll merge it.

@julien-f julien-f merged commit 13837e0 into master Feb 27, 2023
@julien-f julien-f deleted the feat_esxi_api_ux branch February 27, 2023 08:29
pdonias pushed a commit that referenced this pull request Feb 27, 2023
MathieuRA pushed a commit that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants