Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/kubernetes-recipe): add DNS config #6678

Merged
merged 7 commits into from
Apr 20, 2023
Merged

Conversation

ggunullu
Copy link
Contributor

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@ggunullu ggunullu marked this pull request as ready for review March 8, 2023 13:20
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/hub/recipes/recipe-form.js Outdated Show resolved Hide resolved
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a screenshot of the result to the PR description.

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/hub/recipes/recipe-form.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
ggunullu and others added 2 commits March 15, 2023 15:22
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
@pdonias
Copy link
Member

pdonias commented Mar 16, 2023

Ready to merge after xoa#114.

@ggunullu
Copy link
Contributor Author

Ready to merge after xoa#114.

xoa#144 has been merged !

@ggunullu ggunullu requested a review from pdonias April 19, 2023 11:29
@pdonias pdonias changed the title fix(xo-web/kubernetes-recipe): add dns config fix(xo-web/kubernetes-recipe): add DNS config Apr 20, 2023
@pdonias pdonias merged commit 84b75e8 into master Apr 20, 2023
1 check passed
@pdonias pdonias deleted the gab-fix_k8s_recipe branch April 20, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants