Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server): use dcpath in Esxi import #6694

Merged
merged 8 commits into from Mar 6, 2023
Merged

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Mar 1, 2023

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp force-pushed the feat_import_esxi_dcpath branch 2 times, most recently from bceccdd to 7facc78 Compare March 1, 2023 16:29
@fbeauchamp fbeauchamp requested a review from julien-f March 6, 2023 08:05
@fbeauchamp fbeauchamp marked this pull request as ready for review March 6, 2023 08:05
@fbeauchamp fbeauchamp changed the title feat(xo-server): use dcpath feat(xo-server): use dcpath in Esxi import Mar 6, 2023
@fbeauchamp fbeauchamp requested a review from julien-f March 6, 2023 15:09
fbeauchamp and others added 3 commits March 6, 2023 16:15
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
@julien-f julien-f merged commit 86f5f9e into master Mar 6, 2023
1 check passed
@julien-f julien-f deleted the feat_import_esxi_dcpath branch March 6, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants