Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server-perf-alert): skip special SRs which are always full #6755

Merged
merged 9 commits into from
Mar 29, 2023

Conversation

ggunullu
Copy link
Contributor

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@ggunullu ggunullu changed the title fix(xo-server/perf-alert): handle xcp-ng tools fix(xo-server/perf-alert): stop raising alert for xcp-ng tools Mar 28, 2023
@ggunullu ggunullu requested a review from julien-f March 28, 2023 15:49
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@ggunullu ggunullu requested a review from julien-f March 29, 2023 07:24
@ggunullu ggunullu requested a review from julien-f March 29, 2023 07:47
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@ggunullu ggunullu changed the title fix(xo-server/perf-alert): stop raising alert for xcp-ng tools fix(xo-server/perf-alert): add condition to skip alert on specific SRs Mar 29, 2023
@ggunullu ggunullu requested a review from julien-f March 29, 2023 08:22
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
ggunullu and others added 2 commits March 29, 2023 10:40
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
@ggunullu ggunullu requested a review from julien-f March 29, 2023 09:11
@julien-f julien-f changed the title fix(xo-server/perf-alert): add condition to skip alert on specific SRs fix(xo-server-perf-alert): skip special SRs which are always full Mar 29, 2023
@julien-f julien-f merged commit 8c95974 into master Mar 29, 2023
@julien-f julien-f deleted the gab-perf_alert-xcp_ng_tools branch March 29, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants