Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server/OVA import): revert to tar-stream@2 #6779

Merged
merged 2 commits into from Apr 18, 2023
Merged

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Apr 11, 2023

from https://xcp-ng.org/forum/post/60648
introduced by commit 656d13d

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp marked this pull request as ready for review April 17, 2023 10:10
@julien-f julien-f changed the title fix(xo-server): import ova fix(xo-server/OVA import): revert to tar-stream@2 Apr 18, 2023
@julien-f julien-f merged commit 15f69a1 into master Apr 18, 2023
1 check passed
@julien-f julien-f deleted the fix_ova_depend branch April 18, 2023 12:38
@olivierlambert
Copy link
Member

Do we know why a more recent version is failing? Have you reported upstream the issue?

@julien-f
Copy link
Member

@olivierlambert see 15f69a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants