feat(backups): can limit parallel VDI transfers per VM per job #6787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeauchamp
force-pushed
the
feat_concurrency_disk_backup
branch
4 times, most recently
from
eb5d99f
to
6650462
Compare
ggunullu
approved these changes
Jun 26, 2023
julien-f
reviewed
Jun 26, 2023
@xen-orchestra/backups/_runners/_writers/IncrementalRemoteWriter.js
Outdated
Show resolved
Hide resolved
fbeauchamp
force-pushed
the
feat_concurrency_disk_backup
branch
from
fd2c5db
to
732d460
Compare
julien-f
reviewed
Jun 27, 2023
julien-f
reviewed
Jun 28, 2023
CHANGELOG.unreleased.md
Outdated
| @@ -12,6 +12,7 @@ | |||
| - [Plugin/auth-iodc] OpenID Connect scopes are now configurable and `profile` is included by default | |||
| - [Dashboard/Health] Button to copy UUID of an orphan VDI to the clipboard (PR [#6893](https://github.com/vatesfr/xen-orchestra/pull/6893)) | |||
| - [Kubernetes recipe] Add the possibility to choose the version for the cluster [#6842](https://github.com/vatesfr/xen-orchestra/issues/6842) (PR [#6880](https://github.com/vatesfr/xen-orchestra/pull/6880)) | |||
| - [Backups] Add a setting to limit the number of disk transferred in parallel per VM (PR [#6787](https://github.com/vatesfr/xen-orchestra/pull/6787)) | |||
There was a problem hiding this comment.
This is an advanced setting not available in the UI.
If we don't explain it more, we risk to get some questions on this.
Maybe we can do like we did for this release: https://github.com/vatesfr/xen-orchestra/blob/master/CHANGELOG.md#5710-2022-05-31
There was a problem hiding this comment.
that is why I think the configuration variable should be in the configuration file, it would be mostly auto documenting
nerveless, here is the hange
julien-f
changed the title
… VM per job a nw settings is available in the config file : backups.diskPerVmConcurrency , default value 2, which limit the number of disk transfered in parallel during a VM
fbeauchamp
force-pushed
the
feat_concurrency_disk_backup
branch
from
f080697
to
db78439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
On slower infrastructure, VM with huge number ( more than 5 ) of disks may kill the storage.. We limit the transfer to two in parallel per VM, this value can be changed in the config file
Tested : waiting a few hours before starting to transfer does not trigger a timeout
Fixes #007orSee xoa-support#42)CHANGELOG.unreleased.md:${name} v${new version})cron/parse.spec.js)xo-serverAPI changes, the corresponding test has been added to/updated onxo-server-testProcess
WiP:(Work in Progress) if not ready to be mergedFrom the Four Agreements: