Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/SortedTable): handle pending state for collapsed actions #6831

Merged
merged 3 commits into from
May 15, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented May 12, 2023

GIF

Peek 12-05-2023 05-08

Description

Disable running actions to avoid unwanted repetitions of actions.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA requested a review from ByScripts May 12, 2023 08:39
@MathieuRA MathieuRA self-assigned this May 12, 2023
@ByScripts ByScripts requested a review from pdonias May 12, 2023 13:47
@MathieuRA MathieuRA requested review from julien-f and removed request for pdonias May 15, 2023 10:15
@julien-f julien-f changed the title fix(xo-web/sortedTable): for collapsed actions disable the action during action time fix(xo-web/SortedTable): handle pending state for collapsed actions May 15, 2023
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on top of master.

@MathieuRA MathieuRA force-pushed the fix-proxy-force-upgrade branch 3 times, most recently from 09b22a7 to 1bb90a4 Compare May 15, 2023 13:19
@MathieuRA
Copy link
Member Author

Please rebase on top of master.

Done.

@MathieuRA MathieuRA requested a review from julien-f May 15, 2023 13:21
@julien-f julien-f merged commit 13e7594 into master May 15, 2023
1 check passed
@julien-f julien-f deleted the fix-proxy-force-upgrade branch May 15, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants